fix: changed warn to error in ems for key/labels #1981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issuing Ems instancekey is: That's why changing order of |
cgrinds
previously approved these changes
Apr 24, 2023
cgrinds
previously approved these changes
Apr 25, 2023
pkg/util/util.go
Outdated
| @@ -405,3 +406,12 @@ func HasDuplicates(slice []string) bool { | |||
|
|
|||
| return false | |||
| } | |||
|
|
|||
| func GetSortedKeys(instanceKeyMap map[string]string) []string { | |||
There was a problem hiding this comment.
Given its a util method. name of the var instanceKeyMap could be generic. May be just m is fine. You can als change templating.go in rest to use this method.
There was a problem hiding this comment.
Already done the changes in rest/templating.go
rahulguptajss
approved these changes
Apr 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes: